Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565844 Marek Mahut <mmahut@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #10 from Marek Mahut <mmahut@xxxxxxxxxx> 2010-03-02 12:20:07 EST --- - Package meets naming and packaging guidelines - Spec file matches base package name. - Spec has consistant macro usage - Meets Packaging Guidelines - Spec is legible - BuildRequires correct - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package has correct buildroot - Package is a GUI app and has a .desktop file - Package compiles and builds on at least one arch Issues and questions 1. Are you sure we can mix SPL with GPLv2? 2. rpmlint output intellij-idea.i686: E: explicit-lib-dependency cglib intellij-idea.i686: E: devel-dependency java-1.6.0-openjdk-devel intellij-idea.i686: W: incoherent-version-in-changelog 9.0.1.94.310-4 ['9.0.1.94.393-4.fc14', '9.0.1.94.393-4'] intellij-idea.i686: W: unstripped-binary-or-object /usr/lib/idea/bin/libbreakgen.so 3. Are you in touch with upstream regarding your patches? 4. Do you plan to progressively work on enabling other modules? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review