[Bug 551914] Review Request: monodevelop-database - A database plugin for monodevelop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551914

--- Comment #9 from Christian Krause <chkr@xxxxxxxxxxx> 2010-02-28 12:19:30 EST ---
The language problem is not solved:

1. this line is wrong:
%dir %{_libdir}/monodevelop/AddIns/MonoDevelop.Database/locale/*/LC_MESSAGES/*

The contents of the directories
%{_libdir}/monodevelop/AddIns/MonoDevelop.Database/locale/*/LC_MESSAGES are the
actual language files and so they should not be added with the %dir tag.

2. If this line is removed then the package will not build since the actual
language files are not packaged. However, they are intended to be included in
the monodevelop-database.lang file which should be created in the install
section. But this file is empty.

That it does not work is a result of a minor typo in the find/sed call:
it should be "monodevelop/AddIns/MonoDevelop.Database/locale" and not
"monodevelop/AddIns/Monodevelop.Database/locale" (please note the capital "D"
in MonoDevelop in the correct version).

Running rpmlint on the resulting binary rpm also reveals the problem:
monodevelop-database.i686: W: file-not-in-%lang
/usr/lib/monodevelop/AddIns/MonoDevelop.Database/locale/pt/LC_MESSAGES/monodevelop-database.mo

When you rebuild the package, please also add the minor fixes for the
"mixed-use-of-spaces-and-tabs", the "Addin" vs. "Add-in" typo and the
"description-line-too-long" issue in the %description of the devel package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]