[Bug 556346] Review Request: stage - A 2.5D multi-robot simulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556346

--- Comment #10 from Rich Mattes <richmattes@xxxxxxxxx> 2010-02-28 11:52:54 EST ---
(In reply to comment #9)
> Checked -3.
> 
> Some notes:
> 
> * SourceURL
>   - For sourceforge hosted tarball, please follow
>     https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

Fixed this, and tested with spectool -g
> 
> * BR (BuildRequires) for mesa related packages
>   - For historical reason we prefer to use virtually provided dependency
>     to (Build)Requires like "BuildRequires: libGL(U)-devel" instead of
>     using rpm name directly.
> 
Changed the BuildRequires to libGL-devel and libGLU-devel

> * Requires for -devel subpackage
>   - Installed stage.pc contains:
> -----------------------------------------------------------------------
>      7  Libs: -L${prefix}/lib -lstage -lfltk_images -lpng -lz -ljpeg -lfltk_gl
> -lGLU -lGL -lfltk
>      8  Cflags: -I${prefix}/include/Stage-3.2 -I/usr/include/freetype2
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE 
> -----------------------------------------------------------------------
>     This means -devel subpackage should have 
>     "Requires: fltk-devel libpng-devel libjpeg-devel libGL-devel libGLU-devel"
>     ( zlib-devel is pulled in by libpng-devel", freetype-devel is pulled in by
>       fltk-devel )
> 
Added these packages to stage-devel's Requires

> ! BuildRequires in one place
>   - This is not a blocker, however it is more readable to write all
>     BuildRequires in one place instead of seperating them into some
>     subpackages.
> 
No problem, I put them all together

> * pkgconfig Requires
>   - Explicitly writing "Requires: pkgconfig" is no longer needed on
>     Fedora 11 and above.
> 
Removed

> * Macros
>   - Use macros correctly. /usr/share should be %{_datadir}:
>     https://fedoraproject.org/wiki/Packaging/RPMMacros
> 
Missed that one...I changed it to use the macro

> * Build failure
>   - Your srpm fails to build on F-13:
>     http://koji.fedoraproject.org/koji/taskinfo?taskID=2017917
>     This is because Fedora 13 changed the behavior of linker:
>     http://fedoraproject.org/wiki/UnderstandingDSOLinkChange
> 
>     To check F-13 linker behavior on F-12/11, you can do this by adding
> -------------------------------------------------------------
> export LDFLAGS="-Wl,--no-add-needed"
> -------------------------------------------------------------
>   before %cmake line.    

This is where it gets tricky.  I added the ldflags you provided above to my
spec file, and I was able to patch the CMake build files to satisfy the new DSO
link behavior.  I confirmed my changes worked in Mock, with the ldflags enabled
in a fedora-12 build.  When I submitted the new SRPM to Koji, the build failed
because Player has a broken dependency (needs to be rebuilt because OpenCV
changed some sonames).  Player was rebuilt this morning, and once it gets into
F13 Stage should build too.

In the meantime, I'll post my updated spec and SRPM
Spec URL: http://www.richmattes.com/rpms/stage/stage.spec
SRPM URL: http://www.richmattes.com/rpms/stage/stage-3.2.2-4.fc12.src.rpm

rpmlint: 
rpmlint stage.spec ../SRPMS/stage-3.2.2-4.fc12.src.rpm ../RPMS/i686/stage*
../RPMS/noarch/stage*
stage.src: W: spelling-error Summary(en_US) multi -> mulch, mufti
stage.src: W: spelling-error %description -l en_US scalable -> salable,
scalawag, scalar
stage.i686: W: spelling-error Summary(en_US) multi -> mulch, mufti
stage.i686: W: spelling-error %description -l en_US scalable -> salable,
scalawag, scalar
stage.i686: W: shared-lib-calls-exit /usr/lib/libstage.so.3.2.2 exit@xxxxxxxxx
stage-devel.i686: W: spelling-error %description -l en_US libstage -> lib
stage, lib-stage, multistage
stage-devel.i686: W: no-documentation
stage-playerplugin.i686: W: no-documentation
6 packages and 1 specfiles checked; 0 errors, 8 warnings.

Scalable is a word, libstage is the name of the library, and I think multi-* is
acceptable shorthand for multiple *.  I will investigate the shared lib calls
exit further.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]