Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567678 --- Comment #7 from Andrew Dingman <adingman@xxxxxxxxxx> 2010-02-24 05:53:35 EST --- (In reply to comment #3) > The license of the package is GPLv2+. The + means GPLv2 "or any later version" > (in contrast to "version 2 only" = GPLv2). You need look at the headers of the > python files in order to distinguish this because COPYING wont tell. I missed GPLv2+ in the list of available tags. Thanks. > There are a lot of missing Requires: Usually rpmbuild will generate them > automatically, but not for python. You should look at the "import" statements > of the python files, I guess you will need at least pygtk2 and notify-python. I thought I read something saying explicitly not to do that for python, and went back and deleted them. I'll get on that. > GConf schemas are no config files, remove %config(noreplace) and ignore the > warning that rpmlint will return. I wondered. > the rest is added automatically, use 'rpm --eval %configure' to check what the > macro does. Is there any rule for understanding which macros 'rpm --eval' *doesn't* work for? There are plenty of them I run across that display nothing. (%doc is one) I'd trust that I knew what the macros were doing a lot better if that worked consistently or I knew why and when it wouldn't. > If you want to make sure to only include python files, you could use > > %dir %{python_sitelib}/cameramonitor/ > %{python_sitelib}/cameramonitor/*.py* > > Same goes for %{_datadir}/cameramonitor/, it's unowned too. That's what I wanted to do. Thanks. > The *.desktop files need to be installed or validated, see > https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage > Typo in the spec: coppies -> copies Yeah, I can't spell. I should make better use of the "Spell-Check Comments" feature in RPM SPEC mode. I'll post a fixed package shortly. Thank you for the feedback and pointers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review