Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: VDR - Video Disk Recorder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190343 ------- Additional Comments From ville.skytta@xxxxxx 2006-10-15 03:37 EST ------- (In reply to comment #13) > I'll take a stab at a review on this: Thanks! > 1. Shouldn't the -devel subpackage require: > Requires: %{name} = %{version}-%{release} > (And/Or perhaps the api version since you know it?) The devel subpackage is really independent of the main package. The only thing that I can think of justifying the above dependency would be ownership of the %{_libdir}/vdr directory, but I think owning it in both the main package and devel is harmless and better than adding the dependency. If you have strong opinions about this, I don't insist on it though. > 2. Should these be even packaged since they don't contain anything: > %{_libdir}/vdr > %{_libdir}/bin > %{_datadir}/vdr > %{_datadir}/vdr/logos > Or are they needed for some of the other packages that depend on this one? Yes, they're used by plugin packages. %{_libdir}/vdr is the dir where plugins are installed to and from where VDR loads them. %{_libdir}/vdr/bin (not %{_libdir}/bin) contains various executables for plugins - those helpers are supposed to be in $PATH but there's no need to put them in eg. %{_bindir}. %{_libdir}/vdr/bin is put into the vdr process's $PATH by the init script. %{_datadir}/vdr is for various static data files for plugins, such as channel logos etc. > W: vdr incoherent-subsys /etc/rc.d/init.d/vdr $prog > Something going on with the init sript or pid file? Nah, rpmlint bug, see bug 210261 comment 4 and later comments there. > W: vdr non-conffile-in-etc /etc/sysconfig/vdr-plugins.d/README > This README is probibly needed to explain the plugins? Yes, it was needed for that. Nowadays this and other packaging related things are documented in /usr/share/doc/vdr-*/README.package too, so it can be removed. http://cachalot.mine.nu/6/SRPMS/vdr.spec http://cachalot.mine.nu/6/SRPMS/vdr-1.4.3-3.src.rpm * Sun Oct 15 2006 Ville Skyttä <ville.skytta at iki.fi> - 1.4.3-3 - Apply upstream 1.4.3-1 maintenance patch. - Sync with 1.4.3-1.ds, update liemikuutio patch to 1.13. - Drop no longer needed README.plugins.d, README.package is enough (#190343). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review