Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wallpapoz - Gnome Multi Backgrounds and Wallpapers Configuration Tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210467 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-10-15 01:43 EST ------- Well, before fixing 1: > 2. Does the install.py script not work? Why are you doing your own > install in %install. Could some of these changes get submitted upstream? > It looks like they have a custom install.py, perhaps you could get them > to switch to a more standard one? A. This script installs files directly under /usr . This is truly bad. B. Also, I made a change for the file names and the directory the files are installed. B-1. This package installs 0755-permission .py files under /usr/bin . While this is allowed, I think this should be avoided and the name of *.py in /usr/bin should be changed. See the "Unnecessary Byte compilation" of http://fedoraproject.org/wiki/Packaging/Python . B-2 This package installs 0644-permission .py files under /usr/bin . This file needs byte-compiling. I think this is not allowed. So I moved this file to /usr/share/wallpapoz. This needs extra treatments about other installed files. However, all the issues about "B" is fedora-specific and I wonder if I should report this to upstream. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review