Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564466 Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |nicolas.mailhot@xxxxxxxxxxx Flag| |needinfo?(paul@xxxxxxxxxxxx | |k) --- Comment #6 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2010-02-22 09:54:45 EST --- Thanks both of you for the work, sorry I was busy elsewhere, here is a review 1. (blocking) as per fonts packaging guidelines the organisation releasing the fonts should be used to prefix the package name, so the package name should be ubuntu-title-fonts (package names are a PITA to change after import, try to get them right from the start) http://fedoraproject.org/wiki/Packaging:FontsPolicy#Naming 2. It's not a good idea to include this kind of coverage info in the summary, it will (hopefully) change over time and you want the summary to stay invariant (esp. if we finally manage to get them translated) If you want to add coverage hints be very general "partial basic latin" and not so specific (note that "partial basic latin" is already borderline and specific) The rest if fine, just fix this and I'll approve the package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review