Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #4 from Matthew Booth <mbooth@xxxxxxxxxx> 2010-02-22 09:23:19 EST --- rpmlint has been run. Reported errors can be ignored. Package is named according to the package naming guidelines. spec file name matches the base package name Package meets the packaging guidelines Package has an approved license (LGPLv2) spec license matches actual license. LICENSE is included in %doc spec file is in English spec file is legible Sources in srpm match upstream Package builds on at least x86_64 and i686 spec file does not exclude any architectures. All BuildRequires are specified spec file uses %find_lang spec file calls ldconfig in %post and %postun Package does not bundle system libraries Package is not relocatable Package does not explicitly create any directories * Both the base and devel pacakges list %doc LICENSE Permissions are set properly spec file has a %clean section Package uses macros consistently Package doesn't contain any large documentation files %doc files do not affect runtime Header file is in -devel package Package doesn't include any static libraries devel package Requires pkgconfig devel package contains libhivex.so devel package requires exact base package version Package does not contain any libtool archives Package does not any GUI applications Pacakge does not own any files or directories of other packages %install runs rm -rf $RPM_BUILD_ROOT All filenames are valid UTF-8 Additionally: hivex as packaged here would conflict with libguestfs as currently included in Fedora. This is a blocker until libguestfs is updated to remove hivex. hivex should include Conflicts: libguestfs < (version without hivex, when released) libguestfs will presumably require hivex in any case, meaning a user can upgrade seamlessly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review