[Bug 565858] Review Request: rubygem-thin - A thin and fast web server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565858

--- Comment #18 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-02-19 11:18:44 EST ---
(In reply to comment #17)
> Well,
> * Directory ownership issue
>   - Umm... isn't it enough that you write licenses of the included files
>     as comments? Now the following directories are not owned:
> ---------------------------------------------------------------------
> %{geminstdir}/lib/thin/
> {geminstdir}/spec/rails_app/
> ---------------------------------------------------------------------    

Should be FIXED:

Spec URL: http://mifo.sk/rubygem-thin.spec
SRPM URL: http://mifo.sk/rubygem-thin-1.2.5-5.fc12.src.rpm 

Licences:
It's better to have files grouped by Licence.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]