Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565603 --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-02-17 03:02:06 EST --- Thank you for reviewing this. (In reply to comment #2) > Quick initial notes: > - License - the included file says it's GPLv2 - (On Fedora) just putting GPLv2 license text into the tarball does not mean that it is under GPLv2, rather it is under GPL+ https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F > - rpmlint complains of a missing BuildRoot tag - I explicitly removed this because BuildRoot is no longer used. > - As per http://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files > can you add a note about why kitutuki.ksh is %config instead of > %config(noreplace) - Will add in the next "release" (because kitutuki.ksh format may change in the next version as this package is uttely new package, for now I think replacing this file completely when upgrading version is much safer). > Questions: > > As per > http://fedoraproject.org/wiki/Packaging/Guidelines#Summary_and_description > would it make sense to include a Japanese summary/description as I see done in > another package you maintain > http://cvs.fedoraproject.org/viewvc/rpms/eb/devel/eb.spec?revision=1.6&view=markup - Will add Japanese summary/description in the next "release". > Could the english summary/description be improved a bit - they don't say much > about the usefulness of the software. - Unfortunately the upstream does not explain this so much (the main purpose of this package is to be used by mfiler3 of next version - a CUI file manager developed by the same author ) > usage.en.txt is a bit sparse and I'm having trouble figuring out how to best > use/test this. Would it be possible to either include a README.fedora with some > english usage examples or perhaps a google translated version of usage.ja.txt > (http://translate.google.ca/translate?hl=en&sl=ja&tl=en&u=http%3A%2F%2Fmagoazul.com%2Fusage.ja.txt)? > I'm unsure on the Fedora policies here but it might be better than nothing. - Maybe I do when I have some time... however I don't want to translate usage.ja.txt by myself. > I ran README.ja.txt through a google translation > (http://translate.google.ca/translate?u=http%3A%2F%2Fmagoazul.com%2FREADME.ja.txt&sl=ja&tl=en&hl=&ie=UTF-8) > and it tells me to try kitutuki_help: > > mkent@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx /misc/desktop > kitutuki_help > which: no lv in > (/usr/kerberos/sbin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/misc/desktop/bin:/misc/desktop/.gem/ruby/1.8/bin) > /usr/share/doc/kitutuki/usage.en.txt: No such file or directory > > but it's searching the wrong path for usage.en.txt and is missing "lv". After > installing lv: > > mkent@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx /misc/desktop > kitutuki_help > run time err > kitutuki.ksh 237: index -> invalid option number - I didn't notice this. Will fix in the next "release". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review