Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565603 Matthew Kent <mkent@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #2 from Matthew Kent <mkent@xxxxxxxxxxxx> 2010-02-17 02:26:57 EST --- Quick initial notes: - License - the included file says it's GPLv2 - rpmlint complains of a missing BuildRoot tag - As per http://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files can you add a note about why kitutuki.ksh is %config instead of %config(noreplace) Questions: As per http://fedoraproject.org/wiki/Packaging/Guidelines#Summary_and_description would it make sense to include a Japanese summary/description as I see done in another package you maintain http://cvs.fedoraproject.org/viewvc/rpms/eb/devel/eb.spec?revision=1.6&view=markup --- Could the english summary/description be improved a bit - they don't say much about the usefulness of the software. --- usage.en.txt is a bit sparse and I'm having trouble figuring out how to best use/test this. Would it be possible to either include a README.fedora with some english usage examples or perhaps a google translated version of usage.ja.txt (http://translate.google.ca/translate?hl=en&sl=ja&tl=en&u=http%3A%2F%2Fmagoazul.com%2Fusage.ja.txt)? I'm unsure on the Fedora policies here but it might be better than nothing. --- I ran README.ja.txt through a google translation (http://translate.google.ca/translate?u=http%3A%2F%2Fmagoazul.com%2FREADME.ja.txt&sl=ja&tl=en&hl=&ie=UTF-8) and it tells me to try kitutuki_help: mkent@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx /misc/desktop > kitutuki_help which: no lv in (/usr/kerberos/sbin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/misc/desktop/bin:/misc/desktop/.gem/ruby/1.8/bin) /usr/share/doc/kitutuki/usage.en.txt: No such file or directory but it's searching the wrong path for usage.en.txt and is missing "lv". After installing lv: mkent@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx /misc/desktop > kitutuki_help run time err kitutuki.ksh 237: index -> invalid option number -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review