Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561761 --- Comment #5 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-02-13 15:07:16 EST --- Not blockers, but: Replacing PERL_INSTALL_ROOT with DESTDIR would seem to be a good idea, given the recent fun along those lines :) Think about including %{?perl_default_filter} by default, even if just pro forma. It won't hurt anything and might save some pain down the line. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1984104 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 894094d26046006d7afd332ad3860d761ed16405 HTML-Entities-Numbered-0.04.tar.gz 894094d26046006d7afd332ad3860d761ed16405 HTML-Entities-Numbered-0.04.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-HTML-Entities-Numbered-0.04-2.fc13.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-HTML-Entities-Numbered-0.04-2.fc13.noarch.rpm perl(HTML::Entities::Numbered) = 0.04 perl-HTML-Entities-Numbered = 0.04-2.fc13 perl(HTML::Entities::Numbered::Table) = 0.01 ====> requires for perl-HTML-Entities-Numbered-0.04-2.fc13.noarch.rpm perl(base) perl(HTML::Entities::Numbered::Table) perl(:MODULE_COMPAT_5.10.1) perl(strict) perl(vars) =====> perl-HTML-Entities-Numbered-0.04-2.fc13.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-HTML-Entities-Numbered-0.04-2.fc13.src.rpm ====> requires for perl-HTML-Entities-Numbered-0.04-2.fc13.src.rpm perl(ExtUtils::MakeMaker) perl(Test::More) >= 0.32 APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review