Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560894 --- Comment #6 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-02-13 15:02:27 EST --- These aren't blockers, but: Replacing PERL_INSTALL_ROOT with DESTDIR would seem to be a good idea, given the recent fun along those lines :) Think about including %{?perl_default_filter} by default, even if just pro forma. It won't hurt anything and might save some pain down the line. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1984102 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 547ec7392d1082beabfd818cb143f247ee1c7954 Pod-Coverage-TrustPod-0.092830.tar.gz 547ec7392d1082beabfd818cb143f247ee1c7954 Pod-Coverage-TrustPod-0.092830.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-Pod-Coverage-TrustPod-0.092830-2.fc13.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Pod-Coverage-TrustPod-0.092830-2.fc13.noarch.rpm perl(Pod::Coverage::TrustPod) = 0.092830 perl-Pod-Coverage-TrustPod = 0.092830-2.fc13 ====> requires for perl-Pod-Coverage-TrustPod-0.092830-2.fc13.noarch.rpm perl(base) perl(:MODULE_COMPAT_5.10.1) perl(Pod::Coverage::CountParents) perl(Pod::Eventual::Simple) perl(Pod::Find) perl(strict) perl(warnings) =====> perl-Pod-Coverage-TrustPod-0.092830-2.fc13.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Pod-Coverage-TrustPod-0.092830-2.fc13.src.rpm ====> requires for perl-Pod-Coverage-TrustPod-0.092830-2.fc13.src.rpm perl(ExtUtils::MakeMaker) perl(Pod::Coverage) perl(Pod::Eventual::Simple) perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review