[Bug 557021] Review Request: rubygem-merb-gen - Application and plugin generator scripts for Merb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557021

Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |mtasaka@xxxxxxxxxxxxxxxxxxx
               Flag|                            |fedora-review?

Bug 557021 depends on bug 551817, which changed state.

Bug 551817 Summary: Review Request: rubygem-templater - Ruby framework for building code generators
https://bugzilla.redhat.com/show_bug.cgi?id=551817

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |ERRATA

--- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-02-12 12:10:03 EST ---
Looks okay, also your test passes.

One question:
- About "rake spec"
  Currently rake_helpers.rb is missing. Perhaps this file is the below:
  http://github.com/wycats/merb/blob/master/rake_helpers.rb

  Anyway without this file, chaging Rakefile as below seems to
  make "rake spec" pass:
--------------------------------------------------------------------
--- Rakefile.orig       1970-01-01 09:00:00.000000000 +0900
+++ Rakefile    2010-02-13 01:50:28.000000000 +0900
@@ -1,4 +1,10 @@
-require File.expand_path(File.join(File.dirname(__FILE__), "..",
"rake_helpers"))
+#require File.expand_path(File.join(File.dirname(__FILE__), "..",
"rake_helpers"))
+begin ; require "rubygem" ; rescue LoadError ; end
+require "merb-core"
+require "rake"
+require "rake/gempackagetask"
+require "spec"
+require "spec/rake/spectask"

 ##############################################################################
 # Package && release
--------------------------------------------------------------------
  Would you consider to enable %check ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]