[Bug 564412] Review Request: bwping - BWPing is a tool to measure bandwidth and response times between two hosts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564412

Lubomir Rintel <lkundrak@xxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lkundrak@xxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |lkundrak@xxxxx
               Flag|                            |fedora-review+

--- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> 2010-02-12 12:03:30 EST ---
* Correctly named, packing the latest version, using dist tag
* License correct, license file included as documentaion
* SPEC file clean and legible, american english
* Filelist sane
* Reuiqres/provides sane
* Builds fine in mock
* Uses correct compiler flags
* Uses macros consistently

APPROVED

1.) One cosmetic issue:

bwping.i686: W: name-repeated-in-summary BWPing
The name of the package is repeated in its summary.  This is often redundant
information and looks silly in various programs' output.  Make the summary
brief and to the point without including redundant information in it.

Please fix that before importing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]