Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Mohammed Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-02-10 13:06:03 EST --- (In reply to comment #5) > (In reply to comment #4) > > Even though this is in the orphaned specfile, the following line doesn't work > > (try it yourself): > > find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \; > > > > You can replace it w/ this if you want: > > find \( -name '*.class' -o -name '*.jar' \) -exec rm -rf {} \; > > > > or this: > > find ./ -name '*.jar' -exec rm -f '{}' \; > > find ./ -name '*.class' -exec rm -f '{}' \; > fixed as described. > > > > As far as the changelog you have a typo, "Jun 2010" should be "Jan 2010". > fixed. Great, thanks for both of these. > > > > Also why did you remove the previous entries from the changelog > > http://cvs.fedoraproject.org/viewvc/rpms/jcodings/F-11/jcodings.spec?view=markup > The clause with "find" was only a line that has not been changed in the spec. > So, I've considered it as a new package, and a history, from my viewpoint, is > not interesting for anybody. Nevertheless, if you prefer then I'll save the > changelog. Ya, think it's good to leave it in, not only for the specfile but just so we can see the package maintainer history and that it matches up w/ the cvs commit history. > The second release is prepared for review: > Spec URL: http://victorv.fedorapeople.org/files/jcodings.spec > SRPM URL: http://victorv.fedorapeople.org/files/jcodings-1.0.2-2.fc13.src.rpm Excellent, went through all the review guidelines and it fully passes. APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review