Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 --- Comment #5 from Victor G. Vasilyev <victor.vasilyev@xxxxxxx> 2010-02-08 19:01:40 EST --- (In reply to comment #4) First of all, thanks for review. > Looks good for most part, builds find in mock/koji and passes most review > guidelines. > > A couple of specifics though: > > Even though this is in the orphaned specfile, the following line doesn't work > (try it yourself): > find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \; > > You can replace it w/ this if you want: > find \( -name '*.class' -o -name '*.jar' \) -exec rm -rf {} \; > > or this: > find ./ -name '*.jar' -exec rm -f '{}' \; > find ./ -name '*.class' -exec rm -f '{}' \; fixed as described. > > As far as the changelog you have a typo, "Jun 2010" should be "Jan 2010". fixed. > > Also why did you remove the previous entries from the changelog > http://cvs.fedoraproject.org/viewvc/rpms/jcodings/F-11/jcodings.spec?view=markup The clause with "find" was only a line that has not been changed in the spec. So, I've considered it as a new package, and a history, from my viewpoint, is not interesting for anybody. Nevertheless, if you prefer then I'll save the changelog. > > I would leave those in and add a bit about gcj support being removed for > jcodings. I had tried getting gcj/jcodings working myself to no avail, > aot-compile-rpm blocks indefinetly, consuming more and more resources. If you > can figure out the problem, adding gcj support is easy, if not just add a note > to the changelog. > > http://fedoraproject.org/wiki/Packaging/GCJGuidelines As the package was orphaned more than three months and it also has been deprecated I guess it is an updated package. Hence, I use the following rule: https://fedoraproject.org/wiki/Java#Java_on_Fedora "... AOT compilation using GCJ has been deprecated (made optional) and new or updated packages will be built using OpenJDK to produce regular Java bytecode. ..." I don't see any reasons to save gcj bits in the package. The F12 release doesn't include this package, therefore it is a proof that there are not any existing dependencies on the gcj bits of this package, and it can be removed without any problems. And also, I think, it is clear why so dangerously use of a "Java" environment that has not passed the testing via Java Compatibility Kit. I guess we shouldn't spend the time on support of the deprecated technology. The second release is prepared for review: Spec URL: http://victorv.fedorapeople.org/files/jcodings.spec SRPM URL: http://victorv.fedorapeople.org/files/jcodings-1.0.2-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review