Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561391 --- Comment #1 from Tomas Mraz <tmraz@xxxxxxxxxx> 2010-02-03 15:03:43 EST --- (In reply to comment #0) > (There probably was a review in Extras.) > > * rpmlint: > > openct.src:50: W: unversioned-explicit-provides pcsc-ifd-handler > Is there a reason why this needs to be unversioned? No, this is a virtual provide, it was never a package. > > openct.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/openct-0.6.19/wiki/trac.css > OK > > openct.x86_64: W: service-default-enabled /etc/rc.d/init.d/openct > Is this necessary? As this is a hardware device enablement I'd prefer it run by default. It will not harm much (except slower startup) on machines without the hw. > > openct.x86_64: W: missing-lsb-keyword Required-Start in > /etc/rc.d/init.d/openct > > openct.x86_64: W: missing-lsb-keyword Required-Stop in > /etc/rc.d/init.d/openct > OK > > pcsc-lite-openct.x86_64: W: no-documentation > Probably OK > > * Consider shipping NEWS Will do. > * > https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment I'll contact upstream about the udev script patches later. > * http://fedoraproject.org/wiki/Packaging/SysVInitScript says %{_initrddir} is > deprecated and %{_initddir} should be used OK > * "Description:" is mandatory in the LSB header of openct.init OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review