Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Package review: openct https://bugzilla.redhat.com/show_bug.cgi?id=561391 Summary: Package review: openct Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: ASSIGNED Severity: medium Priority: low Component: Package Review AssignedTo: mitr@xxxxxxxxxx ReportedBy: mitr@xxxxxxxxxx QAContact: extras-qa@xxxxxxxxxxxxxxxxx CC: notting@xxxxxxxxxx, tmraz@xxxxxxxxxx, fedora-package-review@xxxxxxxxxx Estimated Hours: 0.0 Classification: Fedora Target Release: --- Miloslav Trmač <mitr@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? (There probably was a review in Extras.) * rpmlint: > openct.src:50: W: unversioned-explicit-provides pcsc-ifd-handler Is there a reason why this needs to be unversioned? > openct.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/openct-0.6.19/wiki/trac.css OK > openct.x86_64: W: service-default-enabled /etc/rc.d/init.d/openct Is this necessary? > openct.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/openct > openct.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/openct OK > pcsc-lite-openct.x86_64: W: no-documentation Probably OK * Consider shipping NEWS * https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment * http://fedoraproject.org/wiki/Packaging/SysVInitScript says %{_initrddir} is deprecated and %{_initddir} should be used * "Description:" is mandatory in the LSB header of openct.init -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review