Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560240 --- Comment #9 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-02-02 06:00:49 EST --- > Should all warnings in libxls be fixed before making libxls > available in fedora? Well, you've already shown that you don't like to fix any of these. It's a tiny package with only few compiler warnings. Fixing real bugs reduces the risk that some of these issues create breakage, which leads to bug reports. > 447 sprintf(ret,""); So what? Even that one would be fixed quickly: ret[0] = '\0'; > most warnings are useful only in debug mode. But still you quoted some which have nothing to do with debug output. E.g. the bad sprintfs in API function xls_getfcell. [Btw, they are not protected against buffer overflows eithers. All the developer does is to add limited safety by creating a static 10KiB array to be used by sprintf. That alone is questionable practise.] > I test the libxls in both i686(rhel) and x84_64(ubuntu), it works OK! So, you have a test-case that tests every possible code path of libxls? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review