Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560258 --- Comment #14 from Chen Lei <supercyper@xxxxxxx> 2010-02-01 00:49:58 EST --- (In reply to comment #13) > formal review is here, see the notes below: > > BAD debuginfo package looks complete. > > - the library is dual-licensed, the right value is GPLv2+ or LGPLv2+ > - you should package the pregenerated html doc and thus having doxygen and > graphviz as BR: is redundant, also running doxygen is not needed and when it's > needed then it must be done carefully because it can cause conflicts in > multilib packages > - the "rm" command removing the internal copy of the minizip library is missing > the path to the files and thus it's a no-op now > - please add a blank line between the changelog entries I fixed all except changing debuginfo package to be looked complete, I don't know how to do it. spec:http://dl.dropbox.com/u/1338197/1/quazip.spec srpm:http://dl.dropbox.com/u/1338197/1/quazip-0.2.3-4.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review