Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560258 --- Comment #13 from Dan Horák <dan@xxxxxxxx> 2010-01-31 10:59:36 EST --- formal review is here, see the notes below: OK source files match upstream: a091dcc3a4d57c2112bff65c2cac70f9f99fcded quazip-0.2.3.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. BAD license field matches the actual license. OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK* BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). BAD debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths, scriptlets exist OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - the library is dual-licensed, the right value is GPLv2+ or LGPLv2+ - you should package the pregenerated html doc and thus having doxygen and graphviz as BR: is redundant, also running doxygen is not needed and when it's needed then it must be done carefully because it can cause conflicts in multilib packages - the "rm" command removing the internal copy of the minizip library is missing the path to the files and thus it's a no-op now - please add a blank line between the changelog entries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review