Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Listen https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193103 ------- Additional Comments From martin.sourada@xxxxxxxxx 2006-10-10 16:17 EST ------- Just few hints about your spec file: >From what I saw in listen sources, musicbrainz support is only runtime, so you should change # MusicBrainz support BuildRequires: python-musicbrainz2 BuildRequires: libtunepimp to # MusicBrainz support Requires: python-musicbrainz2 Requires: /usr/bin/puid Requires: /usr/lib/libtunepimp.so.5 I think. Maybe the last line is optional... since libtunepimp should be loaded due to puid dependency. Next, python-vorbis package seems to be no longer needed in the new version. Maybe the BuildRequires and Requires sections need further review (to look if all optional dependencies aren't omitted during build or in runtime by mistake and if there are not any dependencies no longer needed)? And one question: is it possible to change listen translation files (*.mo) directory from /usr/lib/listen/po/ to fedora default one (/usr/share/locale/) and use then the %find_lang macro? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review