Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ballbuster - Move the paddle to bounce the ball and break all the bricks https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210183 jima@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jima@xxxxxxxxxxxxxx ------- Additional Comments From jima@xxxxxxxxxxxxxx 2006-10-10 15:41 EST ------- (In reply to comment #6) > It will be run if gtk2 isn't installed, but it won't cause any errors > due to use of " || ;". > Read http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?#head- > 7103f6c38d1b5735e8477bdd569ad73ea2c49bda for more informations I was more concerned with "is it necessary?" than "will it error out?" (which, right, it won't). Ultimately it doesn't matter, due to the --no-create (it won't unnecessarily create the file). > I don't think so. hi-color-icon-theme need to be installed because if you > removed that package, it would cause removing of ballbuster.png too > (theoretically). So using it as Requires is good. Now it doesn't make doubt > for me. Yes, but if hicolor-icon-theme gets removed before ballbuster, it won't take the directory with it (as it's non-empty); when ballbuster gets removed (assuming it's the last thing with anything in that directory), the directory will remain on the system, unowned by anything (in an ideal world where it isn't improperly owned by 11 other packages, anyway). But, I'll readily admit that I'm not positive about that. :-) Also, I built the package successfully on devel/i386, FC-5/i386, and FC-5/ppc; it looks like it'll build across all the supported platforms. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review