Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541207 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2010-01-26 12:40:19 EST --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1946344 rpmlint output: liborigin2.x86_64: W: spurious-executable-perm /usr/share/doc/liborigin2-06042009/readme liborigin2.x86_64: W: spurious-executable-perm /usr/share/doc/liborigin2-06042009/copying liborigin2-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 3 warnings. Mostly harmless (consider fixing that, but it's not a review blocker). sources: 8b4443cdc9b30826ded22c6a72e7bea7 liborigin2-20100119.tar.bz2 (confirmed contents match a local svn checkout per instructions in .spec) License: copying file says GPLv3, but source headers all say GPLv2+, please confirm with upstream developers their intent here. (I won't consider this a blocker, as it doesn't affect qtiplot's GPLv2+ licensing). macros: ok scriptlets: ok Esthetically, I don't like Version: 06042009 but as there seems to be no clear upstream version, I don't have any better suggestion either. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review