Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-10-09 23:34 EST ------- Ah, OK. I changed Source0 to http://cheeseshop.python.org/packages/source/T/TurboCheetah/TurboCheetah-%{version}.tar.gz The one remaining issue I see is that this package needs to own /usr/lib/python2.4/site-packages/turbocheetah. * source files match upstream: 52e12130302a218a8e3b925447041be4 TurboCheetah-0.9.5.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: python-turbocheetah = 0.9.5-3.fc6 = python(abi) = 2.4 python-cheetah >= 1.0 * %check is not present; tests not runnable. X needs to own /usr/lib/python2.4/site-packages/turbocheetah * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review