Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nagios-plugins-snmp-disk-proc - Nagios SNMP plugins to monitor remote disk and processes https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202324 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-10-09 23:30 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: cf70e405718d016debe206d01f54262c nagios-snmp-plugins-1.0.tar.gz cf70e405718d016debe206d01f54262c nagios-snmp-plugins-1.0.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. rpmlint says: E: nagios-plugins-snmp-disk-proc-debuginfo description-line-too-long This package provides debug information for package nagios-plugins-snmp-disk-proc. I think this is just due to the very long name of this package, and can be ignored. Everything looks good to me, so this package is APPROVED. Don't forget to close this package NEXTRELEASE once it's been imported and built. Please consider doing a review of another package thats waiting to help spread the reviewing load. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review