Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553683 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Kevin Fenzi <kevin@xxxxxxxxx> 2010-01-21 00:23:45 EST --- Sorry for the delay here. > > 1. Two of the desktop files here (the ones with -su in them) call: > > 'su-to-root'. Where is that provided? Should we just not ship those? > > Or change them to run a different way in Fedora? > > I changed it completely. I use now consolehelper and run the application as > root in general. ok. Sounds good. > > 2. 0.3.5 is out now. Can you update? > > Sure, sorry. missed it. Fixed. Thanks. > > 3. Does smp_mflags not work here? Might note that or add it to the make. > > I use smp_mflags. It's only qmake-qt4 that doesn't understand the > %{_smp_mflags} macro. ok. This package takes a while to build here. ;( > > 5. Do you really need: > > Requires: qt-x11, qt > > It looks to me like the QT requirement is pulled in fine from the binary. > > Hah, you're right. Removed the Requires. > But i had to add a requires for usermode, due to rpmlint. Not sure if it's > really needed or if usermode/consolehelper is installed/used in any spin. Yeah, it should be required I think. You should remember to add changelog and bump the release in reviews... easier to check and confirm what versions the submitter/reviewer have. ;) No biggie though. I don't see any further blockers, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review