Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553683 --- Comment #3 from Thomas Janssen <thomasj@xxxxxxxxxxxxxxxxx> 2010-01-17 10:54:42 EST --- (In reply to comment #2) > Issues: > > 1. Two of the desktop files here (the ones with -su in them) call: > 'su-to-root'. Where is that provided? Should we just not ship those? > Or change them to run a different way in Fedora? I changed it completely. I use now consolehelper and run the application as root in general. > 2. 0.3.5 is out now. Can you update? Sure, sorry. missed it. Fixed. > 3. Does smp_mflags not work here? Might note that or add it to the make. I use smp_mflags. It's only qmake-qt4 that doesn't understand the %{_smp_mflags} macro. > 4. rpmlint says: > luckybackup.i586: W: spelling-error-in-description en_US rsync > luckybackup.i586: W: spelling-error-in-description en_US customizable > luckybackup.src: W: spelling-error-in-description en_US rsync > luckybackup.src: W: spelling-error-in-description en_US customizable > > Can be ignored. > > 5. Do you really need: > Requires: qt-x11, qt > It looks to me like the QT requirement is pulled in fine from the binary. Hah, you're right. Removed the Requires. But i had to add a requires for usermode, due to rpmlint. Not sure if it's really needed or if usermode/consolehelper is installed/used in any spin. http://thomasj.fedorapeople.org/reviews/luckybackup-0.3.5-1.fc12.src.rpm http://thomasj.fedorapeople.org/reviews/luckybackup.spec -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review