Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555941 --- Comment #3 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2010-01-18 14:19:45 EST --- (In reply to comment #2) > Sorry for the delay, eventful weekend... > > > Nitpick 1: > > SPEC file must be in American English: There's a tiny grammatical error in the > package description; there should be no apostrophe in the possessive form of > "it". Fixed. > > Nitpick 2: > > I know it isn't the case for this package, but I think it's good practice to > check for class files and jars in the source for Java packages, as per the Java > package template [1] or the bit of script from the Eclipse plug-in guidelines. > [2] Fixed. Though as an upstream developer I don't think this is needed. > > Nitpick 3: > > Please use %global instead of %defined. [3] If these lines were generated by > RPMStubby, we should probably file a bug there too. Fixed and rpmstubby bug opened. > > > If you are happy to address these three things, then I say this package is > APPROVED. > > > [1] http://fedoraproject.org/wiki/Packaging:Java#ant > [2] http://fedoraproject.org/wiki/Packaging:EclipsePlugins#Pre-built_binaries > [3] > http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define New sources: Spec URL: http://akurtakov.fedorapeople.org/eclipse-manpage.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-manpage-0.0.1-0.svn24060.1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review