Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225920 Daniel Novotny <dnovotny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Flag| |fedora-review+ --- Comment #2 from Daniel Novotny <dnovotny@xxxxxxxxxx> 2010-01-14 10:57:03 EST --- OK source files match upstream: 634dfc172fbf66a6976e2c2c60e2d198 jadetex-3.13.tar.gz OK source contains full URL - downloaded without problems, even from sourceforge :) OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license (freely redistributable). OK license is open source-compatible. License text included in package. - the text seems to be in the file jadetex.dtx, correct me if I'm wrong OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock. N/A debuginfo package looks complete. - no debuginfo needed OK* rpmlint is silent. jadetex.spec: W: no-cleaning-of-buildroot %install jadetex.spec: W: no-cleaning-of-buildroot %clean - rpmlint seems to be confused by usage of shell variables, so this is not a problem jadetex.noarch: W: dangling-relative-symlink /usr/bin/jadetex etex jadetex.noarch: W: dangling-relative-symlink /usr/bin/pdfjadetex pdfetex - these are links to binaries which are in requires jadetex.noarch: W: dangerous-command-in-%post rm - we are rm-ing logs only, this should be ok OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK* scriptlets: there's a %triggerin -- texlive /usr/bin/env - PATH=$PATH:%{_bindir} fmtutil-sys --cnffile %{_datadir}/texmf/tex /jadetex/jadefmtutil.cnf --all > /dev/null 2>&1 exit 0 but that looks quite sane, fmtutil-sys is owned by texlive OK code vs content: collection of TeX macros can be viewed as content, but that's ok OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. Those rpmlint warnings are not a big deal, I found an explanation to all of them, so the package overall looks good. Review +. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review