Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548694 --- Comment #9 from James Laska <jlaska@xxxxxxxxxx> 2010-01-14 10:47:04 EST --- Thanks Jan. rpmlint on the updated packages from comment#8 looks good. # MUST: rpmlint must be run on every package. The output should be posted in # the review.[1] OK $ rpmlint python-rpmfluff.spec python-rpmfluff-0.3-3.fc12.src.rpm /tmp/jlaska-rpm/RPMS/noarch/python-rpmfluff-0.3-3.fc12.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. # MUST: The sources used to build the package must match the upstream source, # as provided in the spec URL. Reviewers should use md5sum for this task. If no # upstream URL can be specified for this package, please see the Source URL # Guidelines for how to deal with this. OK $ curl https://fedorahosted.org/releases/r/p/rpmfluff/rpmfluff-0.3.tar.bz2 | md5sum cd00673f122358f29a2635b96c46a5bd - $ md5sum /tmp/jlaska-rpm/SOURCES/rpmfluff-0.3.tar.bz2 cd00673f122358f29a2635b96c46a5bd /tmp/jlaska-rpm/SOURCES/rpmfluff-0.3.tar.bz2 # SHOULD: The reviewer should test that the package builds in mock. [30] WARN - The package builds locally and through koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1921133 However, one warning message pops out while processing the setup.py bdist command ... setup.py:2: DeprecationWarning: The popen2 module is deprecated. Use the subprocess module. from popen2 import popen2 grep: python-rpmfluff.spec: No such file or directory grep: python-rpmfluff.spec: No such file or directory running install running install_lib This doesn't appear to affect functionality of the built package, but perhaps something to investigate? Additional review steps from https://fedoraproject.org/wiki/Packaging:Python # MUST: Python eggs must be built from source. They cannot simply drop an egg # from upstream into the proper directory. OK, there is no egg file carried in version control and they are build using distutils # MUST: Python eggs must not download any dependencies during the build # process. OK # MUST: If egg-info files are generated by the modules build scripts they must # be included in the package. OK # MUST: When building a compat package, it must install using easy_install -m # so it won't conflict with the main package. N/A # MUST: When building multiple versions (for a compat package) one of the # packages must contain a default version that is usable via "import MODULE" # with no prior setup. N/A # SHOULD: A package which is used by another package via an egg interface # should provide egg info. N/A -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review