Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225743 Daniel Novotny <dnovotny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dnovotny@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dnovotny@xxxxxxxxxx --- Comment #8 from Daniel Novotny <dnovotny@xxxxxxxxxx> 2010-01-14 09:59:46 EST --- seems no-one is assigned here now, I will continue with the review: OK source files match upstream: e6aaab98967f6410099b40f2b3ddebb4 expect-5.43.0.tar.bz2 OK source contains full URL OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license (public domain). OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock. BAD debuginfo package looks complete. - rpmlint warns expect-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/expect-5.43/exp_main_tk.c (maybe that is nothing to worry about, let's see your comments) BAD rpmlint is silent. W: patch-not-applied Patch7: expect-5.43.0-tcl8.5.6.patch (this minor warning can be easily corrected) OK final provides and requires look sane. OK %check is present and all tests pass. BAD shared libraries should be added to the regular linker search paths. every binary RPM package which contains shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. -there's /usr/lib/libexpect5.43.so and no call to /sbin/ldconfig OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in -devel. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - expectk can interact or create gui apps, but isn't one itself, so that's ok the most important issue is imho the /sbin/ldconfig call when we add shared library to /usr/lib -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review