Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554288 Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #3 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> 2010-01-14 09:56:48 EST --- MUST items: [YES] rpmplint is silent [?] Package meets naming guidelines. Please see note (1). [YES] Package meets packaging guidelines. [YES] Spec file matches base package name. [YES] License file is present, matching with spec file, Licensing Guidelines are met. [YES] Spec file is legible and in American English. [YES] Source match upstream. [YES] Package builds OK. [YES] BuildRequires is correct. [YES] ldconfig is called in %post and %postun. [YES] Package doesn't bundle copies of system libraries. [YES] Package owns all the directories it creates. [YES] Package has no duplicity in %files. [YES] Permission on files are set properly. [YES] %clean section is correct. [YES] Spec file has consistant macro usage. [YES] Package is code or permissable content. [YES] %doc files don't affect runtime. [YES] Header files are in -devel package. [YES] pkgconfig -> Requires: pkgconfig is used. [YES] Unversioned libraries in -devel package. [YES] -devel requires the base package using a fully versioned dependency. [YES] No .la libtool archives. [YES] Package doesn't own files/directories that other packages own. [YES] Package has rm -rf RPM_BUILD_ROOT at beginning of %install. [YES] All filenames are valid UTF-8. Should items: [YES] Should builds in mock. [YES] Should have sane scriptlets. [YES] .pc files in -devel. Notes: (1) Marked as (beta) by developer (see CHANGES file), I think it should be named something like this: libid3tag-0.15.1-0.1.b (according to Package Naming Guidelines). But it seems there are only beta releases in. the project, so I am not sure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review