Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554103 --- Comment #4 from pankaj pandey <pankaj86@xxxxxxxxx> 2010-01-13 12:07:10 EST --- Thanks for your valuable inputs Fabian. > - The dist tag is missing. > https://fedoraproject.org/wiki/Packaging:DistTag I did check the page and put the DistTag once in the spec once and then saw that it generated .fc12 srpm, which i did not like so i had removed the DistTag since it wasn't mandatory. I have put it back again. > - The license is GPLv2+, check source file header ...(at your option) any later > version. Changed > - Add %{?_smp_mflags} to make > https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make Added, thanks. > - If this is a GUI application, a .desktop file is needed > https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files I've added this one (though there's no icon yet for fgrun), with some help from pclos srpm. Is there any way to verify if it is working properly. > - Isn't 'make install' missing in the %install section. There is only another > make. Corrected. That was probably a typo. > - Aren't your requirements (fltk, SimGear, sg3_utils) automatically picked by > RPM? Changed (removed few requires). RPM does indeed pick up the required linked libraries as dependencies. Thanks. New version : Spec file : http://sites.google.com/site/pankaj86/files/fgrun.spec?revision=9 SRPM file : http://sites.google.com/site/pankaj86/files/fgrun-1.5.1-1.fc12.src.rpm?revision=4 @ Stefan Riemens Comment#1 It'd be great if you can check the package if it shows the airports list on x86. Also it'd be great if you could post your spec so that i may also try it on my x86_64 and see what the problem may be. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review