Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554103 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #3 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2010-01-13 04:43:45 EST --- Just some quick comments on your spec file. - The dist tag is missing. https://fedoraproject.org/wiki/Packaging:DistTag - The license is GPLv2+, check source file header ...(at your option) any later version. - Add %{?_smp_mflags} to make https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make - If this is a GUI application, a .desktop file is needed https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - Isn't 'make install' missing in the %install section. There is only another make. - Aren't your requirements (fltk, SimGear, sg3_utils) automatically picked by RPM? - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review