Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-eyed3 - Python module for processing ID3 tags https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209894 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pertusus@xxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From pertusus@xxxxxxx 2006-10-07 12:53 EST ------- * as it is a noarch package it may be better to have BuildRequires: python instead of BuildRequires: python-devel * you could remove the -f option of rm such that it breaks if the file isn't there anymore * You could add README.html and THANKS to %doc * the build is done twice since make triggers the build and the install target depends on all. So I think the make in %build should be removed or commented out with a comment indicating that install triggers the build unconditionally * I think that it would be better to have a * for man files to catch man pages when no compressed or compressed using something different than gz, like %{_mandir}/man1/*.1* * Given that it only creates the directory in python_sitelib, you may optionally set %{python_sitelib}/eyeD3/ instead of %{python_sitelib}/* These issues are not blockers. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review