Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550369 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-12-24 18:52:50 EDT --- Review: Good: - license ok - %files ok - %doc ok - permissions ok - parallel make - name ok - url ok - buildroot ok - no BR/R ok - no *.la - no libs - rpmlint clean Comment: Is there a reason, why not using %makeinstall? from https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used "%makeinstall is a kludge that can work with Makefiles that don't make use of the DESTDIR variable" There is no DESTDIR variable, and %makeinstall works (only wrong permissions, that can be fixed after that or/and complained upstream.) Doing the install like this is ok, too; but I prefer %makeinstall in this case... So please consider changing to %makeinstall :) ################################################# APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review