Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 --- Comment #3 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-12-24 18:33:14 EDT --- I did a quick test without autoconf, just used '%configure --docdir=%{_defaultdocdir}/%{name}-%{version}' and the doc stuff is in the right place. If this really works the way it should there are no BR needed and the %install section only needs 'make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"' - Please add '%{?_smp_mflags}' to make https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make - A blank line between the changelog entries would be nice ;-) - Without further investigation I would say that '%attr(755,root,root)' is not needed for '%{_bindir}/procServ' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review