Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scrot - Screen-shot capture using Imlib2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208424 ------- Additional Comments From bugs.michael@xxxxxxx 2006-10-04 17:10 EST ------- Right. That was just a hint, a recommendation to be careful during package review, since this can be an issue also with other packages. And sometimes it changes unexpectedly when upstream modifies the Makefile setup (e.g. our optflags might get overruled). Here it is not a MUST FIX item. Just something to comment on. > I/usr/X11R6/include -I/usr/include -I/usr/include To expand on that, /usr/include is a standard search path for include files. It need not be added to the user search list with -I again. It is harmless with this package, but with other packages it can happen that the added -I/usr/include enters packaged files and propagates to other packages via build requirements. As a worst-case, the modified search order for include files makes it impossible to customise the search path further in order to locate the desired headers. In other words, standard search locations suddenly override user-defined locations, boom. This is a common mistake by some upstream projects. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review