[Bug 208424] Review Request: scrot - Screen-shot capture using Imlib2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scrot -  Screen-shot capture using Imlib2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208424


pertusus@xxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus@xxxxxxx




------- Additional Comments From pertusus@xxxxxxx  2006-10-04 16:22 EST -------
In src/(In reply to comment #3)
 
> I am not sure exactly what to do here with the Makefile.am  I also have no idea
> what you mean about the -O3 Would you be able to provide me with some more input?

If you look at the compilation, you'll notice that there is
   gcc -DHAVE_CONFIG_H -I. -I. -I. -g -O3 -Wall
and the RPM_OPT_FLAGS options on the same line 
   -O2 -g -pipe -Wall   -Wp,-D_FORTIFY_SOURCE=2 -fexceptions 
   -fstack-protector   --param=ssp-buffer-size=4 -m32 -march=i386 
   -mtune=generic -fasynchronous-unwind-tables
In that case the RPM_OPT_FLAGS (and specifically -O2) override the
other flags hardcoded in Makefile.am (and specifically -O3). That's
right, but the flags -g -O3 -Wall shouldn't have been set in the
first place. The upstream is broken, and should be notified that
those flags appearing in src/Makefile.am

INCLUDES          = -g -O3 -Wall -I/usr/X11R6/include \
$(X_CFLAGS) -I$(prefix)/include -I$(includedir) -I. \
-DPREFIX=\""$(prefix)"\" @GIBLIB_CFLAGS@

should be removed, (together with some -I which shouldn't be 
set here) such that the line looks like something along
   INCLUDES          = $(X_CFLAGS) -DPREFIX=\""$(prefix)"\" @GIBLIB_CFLAGS@
(or
   INCLUDES          = $(X_CFLAGS) -DPREFIX=\""$(prefix)"\" $(GIBLIB_CFLAGS)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]