Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547655 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |rc040203@xxxxxxxxxx --- Comment #2 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2009-12-16 03:44:08 EDT --- (In reply to comment #1) > For obvious reasons, I am going to review this ;) > Thanks :-) > * MUSTFIX: Your patch creates a backup files, which gets installed: > > # rpm -qlp perl-Module-Install-RTx-0.25-2.fc12.noarch.rpm > /usr/lib/perl5/vendor_perl/5.10.0/Module > /usr/lib/perl5/vendor_perl/5.10.0/Module/Install > /usr/lib/perl5/vendor_perl/5.10.0/Module/Install/RTx > /usr/lib/perl5/vendor_perl/5.10.0/Module/Install/RTx.pm > /usr/lib/perl5/vendor_perl/5.10.0/Module/Install/RTx.pm.try_RTHOME_first > /usr/lib/perl5/vendor_perl/5.10.0/Module/Install/RTx/Factory.pm > /usr/share/doc/perl-Module-Install-RTx-0.25 > /usr/share/doc/perl-Module-Install-RTx-0.25/Changes > /usr/share/doc/perl-Module-Install-RTx-0.25/README > /usr/share/man/man3/Module::Install::RTx.3pm.gz > > Note the file named RTx.pm.try_RTHOME_first. > oops, will fix. > > * Can you explain your patch? > The original code first searches @INC, then searches the other (IMO > questionable) places. As this module's purpose is to first check where RT is > installed on a system, your patch IMO is wrong. > The problem is it tries to use LocalPath from the @INC RT.pm, which is set to /usr/local/lib/rt3, thus installing the extension to the wrong place. So I create another RT.pm for the installation purpose and force the use of it thru the RTHOME envvar. However, the RT.pm from @INC is preferred over the one from RTHOME, which is a dubious in my opinion. If one is forcing the use of a RTHOME, one would assume this will be the first tried location, hence the patch. > Did you propose your patch to upstream? Yup, I linked the bug in the spec. No answer yet, but I logged it yesterday, so no surprise. http://rt.cpan.org/Ticket/Display.html?id=52776 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review