Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #4 from ELMORABITY Mohamed <melmorabity@xxxxxxxxxxxxxxxxx> 2009-12-15 05:47:02 EDT --- I forgot also 2 points ^^ * Your icons scriplets look strange... Why not referring to the specific guidelines? http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache * You should also maybe tag of the files in %{_defaultdocdir}/%{name}/* (here AUTHORS and MAINTAINERS files) as "%doc", like this in your %files section: %doc %{_defaultdocdir}/%{name}/* Don't forget by the way to set the package as the owner of the %{_defaultdocdir}/%{name}/ directory by adding this in %files: %dir %{_defaultdocdir}/%{name}/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review