[Bug 542715] Review Request: RabbitVCS - Easy version control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542715





--- Comment #3 from ELMORABITY Mohamed <melmorabity@xxxxxxxxxxxxxxxxx>  2009-12-14 20:58:07 EDT ---
Thanks for the update.
You're right indeed about the package architecture, sorry, I talked by the way
with the phatch maintener who is exactely in the same case than you (a
full-Python application with a Nautilus plugin that must be in %{_libdir}/) :-)
Anyway you should had this line at the top of your spec file:
    %global debug_package %{nil}
Otherwise a useless (and empty!) debug package will be generated

In your %install section, you launch the installation with this command:
    %{__python} setup.py install -O1 --root $RPM_BUILD_ROOT
Is there any reason to specify the « -O1 » option? Some optimizations at the
installation are really required here?

About the BuildRequires, neither gtk2-devel nor nautilus-python maybe required
for the build. pygtk2 and python-devel are enough here. By the way, in the
Requires, you don't need also python, it is detected automatically as a
Requires by rpmbuild. You don't need also to add pyobject2 as a Requires since
pygtk2 is always declared as a Requires and requires pyobject2.

I've rebuild your package and rpmlint complains about some issues:
- on your SRPM:
     rabbitvcs.src: W: strange-permission rabbitvcs-0.12.1.tar.gz 0777
     rabbitvcs.src: W: strange-permission rabbitvcs.spec 0777
  you should remove the executables bits from this files in your build root.
- on your generated RPM:
     rabbitvcs.x86_64: W: obsolete-not-provided nautilussvn
        See
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages
     rabbitvcs.x86_64: E: no-binary
         It is a false-positive because of the Nautilus extension issue you
explained above, no matter I think ;)
     rabbitvcs.x86_64: E: non-executable-script
/usr/lib/python2.6/site-packages/rabbitvcs/debug/ipython_view.py 0644
/usr/bin/python
          rabbitvcs.x86_64: E: non-executable-script
/usr/share/rabbitvcs/do-rabbitvcs-restart-nautilus 0644 /bin/sh
         This file has a shebang, you should remove it using sed as described
here:
             
http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Remove_shebang_from_files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]