Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226050 --- Comment #8 from Karel Klíč <kklic@xxxxxxxxxx> 2009-12-10 06:12:39 EDT --- [YES] source files match upstream: a4b36980765003b47dd75ac9429f4f11 libtool-2.2.6b.tar.lzma [YES] package meets naming and versioning guidelines [YES] specfile is properly named [YES] specfile is cleanly written [???] uses macros consistently: %{name} should be used instead of $PACKAGE and %{_datadir} instead of $datadir [YES] dist tag is present [YES] build root is correct [YES] license field matches the actual license [YES] license is open source-compatible [YES] license text included in package [YES] latest version is being packaged [???] BuildRequires are proper: no need to include gcc and gcc-c++, because they are added automatically [YES] compiler flags are appropriate [YES] %clean is present [YES] package builds in mock [YES] debuginfo package looks complete [NO] rpmlint is silent $ rpmlint *.rpm libtool.i686: E: no-binary libtool.i686: W: file-not-utf8 /usr/share/doc/libtool-2.2.6/ChangeLog.2002 libtool.i686: E: script-without-shebang /usr/share/libtool/config/ltmain.sh libtool.i686: W: file-not-utf8 /usr/share/doc/libtool-2.2.6/ChangeLog.1998 libtool.i686: W: file-not-utf8 /usr/share/doc/libtool-2.2.6/ChangeLog.1999 libtool.i686: W: file-not-utf8 /usr/share/doc/libtool-2.2.6/ChangeLog.1997 libtool-debuginfo.i686: W: hidden-file-or-dir /usr/src/debug/libtool-2.2.6b/libltdl/.libs libtool-debuginfo.i686: W: hidden-file-or-dir /usr/src/debug/libtool-2.2.6b/libltdl/.libs libtool-ltdl.i686: W: shared-lib-calls-exit /usr/lib/libltdl.so.7.2.1 exit@xxxxxxxxx libtool-ltdl-devel.i686: W: no-documentation 5 packages and 0 specfiles checked; 2 errors, 8 warnings. [YES] final provides and requires look sane [OK] %check is present, but "make check" is commented out [YES] no shared libraries are added to the regular linker search paths in app package [YES] owns the directories it creates [YES] doesn't own any directories it shouldn't [YES] no duplicates in %files [YES] file permissions are appropriate [YES] scriptlets ok [YES] code, not content [YES] documentation is small, so no -docs subpackage is necessary [YES] %docs are not necessary for the proper functioning of the package [YES] no headers [YES] no pkgconfig files [YES] no libtool .la droppings [YES] not a GUI app -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review