Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540368 --- Comment #5 from Chen Lei <supercyper@xxxxxxx> 2009-12-08 09:44:35 EDT --- Thankkee Jan! I modified my spec files. New spec and SRPMS SPEC: http://dl.dropbox.com/u/1338197/1/llk_linux.spec SRPM: http://dl.dropbox.com/u/1338197/1/llk_linux-2.3-0.2.beta1.fc12.src.rpm Some changes 1. I bumpd the release from 0.1.beta1%{?dist} to 0.2.beta1%{?dist}. 2. I think the version of llk_linux should retain 2.3 rather than 2.3beta1, beta1 should in the release number. See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease 3. This package successfully honored compiler flags in Makefile by default, so we do not need to set $RPM_OPT_FLAGS/%{optflags} 4. I followed the guideline to intall desktop file, however the desktop file still need some additional modification such as adding a key to the desktop file or changing the content of a key that cannot accomplished by desktop-file-intall. 5. I removed comments in files section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review