Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540368 --- Comment #4 from Jan Klepek <jan.klepek@xxxxxx> 2009-12-07 11:48:33 EDT --- 1] Please bump Release each time you perform any change into spec file 2] In spec file you have: Version: 2.3 Release: 0.1.beta1%{?dist} However, version of llk is 2.3beta1 Imho you should have following in spec file (and update Source link to reflect this): Version: 2.3beta1 Release: 1%{?dist} And bump Release each change in spec file (so now it should be: Release: 2%{?dist} next version should have: Release: 3%{?dist} etc...) 3] Are compiler flags honored in Makefile by default? If no, you should honor them correctly http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags 4] if possible, you should use following way how to install desktop file http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage 5] comments in files section should be removed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review