Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536737 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #5 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-12-02 00:17:39 EDT --- + is Ok - Needs work Review: + package builds in mock (rawhide i686). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1842652 + rpmlint is NOT silent for SRPM but is silent for RPM. yum-langpacks.src:36: E: hardcoded-library-path in %{_prefix}/lib/yum-plugins/langpacks.py* ==>rpmlint message looks ok and can be ignored as this is noarch package. - Source URL is not working. + source files match(sha1sum) upstream url http://petersen.fedorapeople.org/yum-langpacks/yum-langpacks-0.1.4.tar.gz as 679464156861fb0af5d791d501f8eb597e10d518 yum-langpacks-0.1.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: 1) Note that you can safely remove buildroot tag and cleanup of buildroot as per givaen at http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag and http://fedoraproject.org/wiki/PackagingGuidelines#Prepping_BuildRoot_For_.25install 2) update source url to correct download url. 3) Use %global instead of %define as per given at http://fedoraproject.org/wiki/PackagingGuidelines#.25global_preferred_over_.25define 4) remove unnecessary Requires: python >=2.4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review