Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542436 --- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-11-30 16:54:19 EDT --- Hi Andrew, you are welcome. No, you *should* query upstream to add a COPYING file, if it doesn't exist already. If there is a COPYING file, this *has* to be in %doc. You 'just' changed the spec file and rebuilded the src.rpm. Please always bump the relase and add a changelog line, when you have changed anything: Like ============================= %changelog * Mon Oct 30 2009 Andrew "acturneruk" Turner <email@xxxxxxxxxxx> 1.6.0-2 - adding %%doc - %%global instead of %%define * Mon Oct 20 2008 Andrew "acturneruk" Turner <email@xxxxxxxxxxx> 1.6.0-1 - Initial package for Fedora ============================= Note the %%doc and not %doc. When just using %doc, rpmlint complains about 'using a macro in %changelog'. After that, you should repost the SPEC and SRPM url and not just point to the ones in your first comment. Thomas -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review