Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Listen https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193103 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-10-01 17:02 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: 1a008fbf898c4cfe2b0efd58905463a1 listen-0.4.3.tar.gz 998a9df094ee72efc84253f36a957b5c listen-0.4.3.tar.gz.1 See below - Package compiles and builds on at least one arch. Pending - BuildRequires correct Pending - Package owns all the directories it creates. Pending - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. See below - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package is a GUI app and has a .desktop file Pending - Package doesn't own any directories other packages own. Pending - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. See below - Should build in mock. Issues: 1. Could you re-name the two patches to have 'listen-' on the front? Makes them easier to find in a SOURCES directory. 2. The desktop file adds the following mime types: MimeType=audio/x-musepack;application/x-musepack;audio/musepack;application/ musepack;application/x-ape;audio/ape;audio/x-ape;audio/x-musepack;application/x- musepack;audio/musepack;application/musepack;application/x-ape;audio/ape;audio/ x-ape;audio/x-mp3;application/x-id3;audio/mpeg;audio/x-mpeg;audio/x-mpeg- 3;audio/mpeg3;audip/mp3;audio/x-mp3;application/x-id3;audio/mpeg;audio/x- mpeg;audio/x-mpeg-3;audio/mpeg3;audip/mp3;audio/x-m4a;audio/x-m4a;audio/ mpc;audio/x-mpc;audio/mp;audio/x-mp;audio/mpc;audio/x-mpc;audio/mp;audio/x- mp;application/ogg;application/x-ogg;audio/vorbis;audio/x-vorbis;audio/ ogg;audio/x-ogg;application/ogg;application/x-ogg;audio/vorbis;audio/x- vorbis;audio/ogg;audio/x-ogg;audio/x-flac;application/x-flac;audio/flac;audio/x- flac;application/x-flac;audio/flac; Perhaps remove the ones it can no longer handle without libmad? 3. The sources don't match upstream. It appears your source has a link from listen to listen.py that the upstream doesn't have. You should use the upstream source and only add things in the build process. 4. You are mixing usage of the %{buildroot} and $RPM_BUILD_ROOT macros. Pick one and use only that one. 5. It doesn't seem to build under mock. It gets to the Xvfb stuff, but never past it. Does it work for you under mock? I know other packages that have needed an X server have used this, so you might check other packages in extras for working magic on this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review